cpp: add build-time flags to make compression dependencies optional #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New defines: MCAP_COMPRESSION_NO_ZSTD, MCAP_COMPRESSION_NO_LZ4
james-rms
changed the title
james-rms
force-pushed
the
jrms/cpp-optional-compression-dependencies
branch
from
d183f9a
to
6839722
Compare
|
Well, I was lazy with my PR, but if you are not I have a few suggestions:
PS: oh, ok i guess too late. |
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
…oxglove#1013) ### Public-Facing Changes Adds two new build-time flags to optionally disable `zstd` and `lz4` support. These are `MCAP_COMPRESSION_NO_ZSTD` and `MCAP_COMPRESSION_NO_LZ4`. When reading MCAP files, if the reader encounters a known compression method but is compiled without support for it, it will yield `Status::UnsupportedCompression`. ### Description Based on foxglove#1008 A new test binary is added to CI, which exercises these build-time flags. --------- Co-authored-by: Alexander Sherikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
Adds two new build-time flags to optionally disable
zstdandlz4support. These areMCAP_COMPRESSION_NO_ZSTDandMCAP_COMPRESSION_NO_LZ4.When reading MCAP files, if the reader encounters a known compression method but is compiled without support for it, it will yield
Status::UnsupportedCompression.Description
Based on #1008
A new test binary is added to CI, which exercises these build-time flags.