do not render hz if no messages #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-rms
force-pushed
the
james/fg-5522-cli-0-msgs-nan-hz-foxglovemcap-1004
branch
from
956c05b
to
7f88fd9
Compare
jtbandes
approved these changes
Nov 1, 2023
james-rms
deleted the
james/fg-5522-cli-0-msgs-nan-hz-foxglovemcap-1004
branch
Closed
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes
For `mcap info`, removes channel hz display if there are no or one
messages in a channel. This avoids displaying an ugly `NaN` or `Inf`.
Before:
```
j@192-168-1-108 python % mcap info ~/this.mcap
library: python mcap 1.1.1
profile:
messages: 1
duration: 0s
start: 2023-11-02T05:34:10.165983+11:00 (1698863650.165983000)
end: 2023-11-02T05:34:10.165983+11:00 (1698863650.165983000)
compression:
zstd: [1/1 chunks] [234.00 B/153.00 B (34.62%)]
channels:
(1) sample_topic 0 msgs (NaN Hz) : sample [jsonschema]
(2) sample_topic 1 msgs (+Inf Hz) : sample [jsonschema]
attachments: 0
metadata: 0
```
After:
```
j@192-168-1-108 mcap % ./bin/mcap info ~/this.mcap
library: python mcap 1.1.1
profile:
messages: 1
duration: 0s
start: 2023-11-02T05:34:10.165983+11:00 (1698863650.165983000)
end: 2023-11-02T05:34:10.165983+11:00 (1698863650.165983000)
compression:
zstd: [1/1 chunks] [234.00 B/153.00 B (34.62%)]
channels:
(1) sample_topic 0 msgs : sample [jsonschema]
(2) sample_topic 1 msgs : sample [jsonschema]
attachments: 0
metadata: 0
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
For
mcap info, removes channel hz display if there are no or one messages in a channel. This avoids displaying an uglyNaNorInf.Before:
After: