Pin pipenv to an older version #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-run pipenv update. I don't see this dependency imported anywhere, and it appears to be the cause of `pipenv update` failures locally and in CI.
wkalt
approved these changes
Aug 29, 2023
wkalt
approved these changes
Aug 30, 2023
bryfox
deleted the
bryan/fg-4768-py-data-platform-ci-fails-trying-to-install-rosbag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is currently failing (example) because pipenv is seemingly unable to find dependencies from the rospypi index. I can reproduce this locally with pipenv versions 2023.7.23 and 2023.8.28. Locally, installing these dependencies directly with
pip install --extra-index-urlworks fine, as does reverting to an older version of pipenv. Version 2023.6.18 was the version used in the latest successful CI run.Prior versions of this PR attempted to remove the rosbag dependency and use an updated lockfile with latest pipenv, but that caused different errors, including
std_messagesto resolve to an incorrect version from pypi.org even though the index was specified.This is a temporary workaround. We'll need to find a better fix here, but I don't have enough knowledge of this ecosystem to understand what's happening. I do see that version 2023.7.23 mentions changes related to compatibility checks.
The other changes here are minor: