Skip to content

Commit

Permalink
again try to fix cla issues
Browse files Browse the repository at this point in the history
  • Loading branch information
cdc97 committed Aug 30, 2023
1 parent 7cf3207 commit 97b883d
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
python:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: 3.7
python-version: 3.8
cache: pipenv
- run: pip install pipenv
- run: pip install pipenv==2022.12.19
- run: pipenv install --dev --deploy
- run: pipenv run black --check --diff --color --exclude '.*_pb2.py' .
- run: pipenv run pyright foxglove_data_platform
Expand Down
6 changes: 6 additions & 0 deletions foxglove_data_platform/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,12 @@ def delete_import(self, *, device_id: Optional[str] = None, import_id: str):
)
json_or_raise(response)

def delete_recording(self, *, recording_id: str):
response = requests.delete(
self.__url__(f"/v1/recordings/{recording_id}"), headers=self.__headers
)
json_or_raise(response)

def get_imports(
self,
*,
Expand Down
15 changes: 15 additions & 0 deletions tests/test_recordings.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,21 @@
fake = Faker()


@responses.activate
def test_delete_recording():
recording_id = fake.uuid4()
responses.add(
responses.DELETE,
api_url(f"/v1/recordings/{recording_id}"),
json={"success": True, "id": recording_id},
)
client = Client("test")
try:
client.delete_recording(recording_id=recording_id)
except:
assert False


@responses.activate
def test_get_recordings():
device_id = fake.uuid4()
Expand Down

0 comments on commit 97b883d

Please sign in to comment.