Skip to content

Commit

Permalink
use mcap as default OutputFormat (#110)
Browse files Browse the repository at this point in the history
### Changelog

Use `mcap` as the default OutputFormat.

### Docs

None

### Description

Support `mcap` and use it as the default OutputFormat. It functions the
same as `mcap0`, which is being deprecated in favor of using `mcap`.

Fixes FG-9084
  • Loading branch information
mguida22 authored Oct 21, 2024
1 parent a001081 commit 88aeff5
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions foxglove/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ def __call__(self, size: int, progress: int) -> None:

class OutputFormat(Enum):
bag = "bag1"
mcap = "mcap"
mcap0 = "mcap0"


Expand Down Expand Up @@ -361,7 +362,7 @@ def download_recording_data(
*,
id: Optional[str] = None,
key: Optional[str] = None,
output_format: OutputFormat = OutputFormat.mcap0,
output_format: OutputFormat = OutputFormat.mcap,
include_attachments: bool = False,
callback: Optional[ProgressCallback] = None,
):
Expand Down Expand Up @@ -402,7 +403,7 @@ def _make_stream_link(
start: datetime.datetime,
end: datetime.datetime,
topics: List[str] = [],
output_format: OutputFormat = OutputFormat.mcap0,
output_format: OutputFormat = OutputFormat.mcap,
) -> str:
if device_id is None and device_name is None:
raise RuntimeError("device_id or device_name must be provided")
Expand Down Expand Up @@ -431,7 +432,7 @@ def download_data(
start: datetime.datetime,
end: datetime.datetime,
topics: List[str] = [],
output_format: OutputFormat = OutputFormat.mcap0,
output_format: OutputFormat = OutputFormat.mcap,
callback: Optional[ProgressCallback] = None,
) -> bytes:
"""
Expand Down

0 comments on commit 88aeff5

Please sign in to comment.