Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update template to avoid potential memory leaks #154

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update template to avoid potential memory leaks #154

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a9c5f5
add comment about hook dependencies and cleanup function
achim-k Sep 4, 2024
cb3aeeb
remove closure for done callback
achim-k Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion template/src/ExamplePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ function ExamplePanel({ context }: { context: PanelExtensionContext }): JSX.Elem
// subscribe to some topics, you could do this within other effects, based on input fields, etc
// Once you subscribe to topics, currentFrame will contain message events from those topics (assuming there are messages).
context.subscribe([{ topic: "/some/topic" }]);
}, [context]);

return () => {
context.onRender = undefined;
setRenderDone(undefined);
};
}, [context]); // Adding other dependencies here is discouraged as it can lead to memory leaks. Consider using other effects for your panel logic.

// invoke the done callback once the render is complete
useEffect(() => {
Expand Down
Loading