Skip to content

Commit

Permalink
Eliminate non-existent headers from GLFW build (#778)
Browse files Browse the repository at this point in the history
The GLFW BUILD.gn file refers to several headers that don't exist in the
repo.

Issue: flutter/flutter#136284

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
  • Loading branch information
cbracken authored Oct 10, 2023
1 parent 88b37b9 commit 1d2965f
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions build/secondary/flutter/third_party/glfw/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ source_set("glfw") {
if (is_win) {
sources += [
"$_checkout_dir/src/wgl_context.c",
"$_checkout_dir/src/wgl_context.h",
"$_checkout_dir/src/win32_init.c",
"$_checkout_dir/src/win32_joystick.c",
"$_checkout_dir/src/win32_joystick.h",
Expand All @@ -60,7 +59,6 @@ source_set("glfw") {
} else if (is_linux) {
sources += [
"$_checkout_dir/src/glx_context.c",
"$_checkout_dir/src/glx_context.h",
"$_checkout_dir/src/linux_joystick.c",
"$_checkout_dir/src/linux_joystick.h",
"$_checkout_dir/src/posix_module.c",
Expand Down Expand Up @@ -99,7 +97,6 @@ source_set("glfw") {
"$_checkout_dir/src/cocoa_platform.h",
"$_checkout_dir/src/cocoa_time.c",
"$_checkout_dir/src/cocoa_window.m",
"$_checkout_dir/src/nsgl_context.h",
"$_checkout_dir/src/nsgl_context.m",
"$_checkout_dir/src/posix_module.c",
"$_checkout_dir/src/posix_thread.c",
Expand Down

0 comments on commit 1d2965f

Please sign in to comment.