Skip to content

Commit

Permalink
Move //third_party/glfw to //flutter/third_party/glfw (#777)
Browse files Browse the repository at this point in the history
As part of eliminating the Flutter buildroot (#67373), we are moving all
third-party dependencies from //third_party to //flutter/third_party.

This will be followed by an engine PR that updates the deps pull GLFW to
//flutter/third_party/glfw and update all targets to point to the new
location.

Once all third-party dependencies have been migrated, tooling and config
will be moved and the buildroot will be eliminated altogether.

Issue: flutter/flutter#136284

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
  • Loading branch information
cbracken authored Oct 10, 2023
1 parent 50cb790 commit 88b37b9
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import("glfw_args.gni")

_checkout_dir = "//third_party/glfw"
_checkout_dir = "//flutter/third_party/glfw"

config("relative_glfw_headers") {
include_dirs = [
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion build/secondary/third_party/imgui/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ config("imgui_headers") {
source_set("imgui_glfw") {
public_deps = [
":imgui",
"//third_party/glfw",
"//flutter/third_party/glfw",
]

public_configs = [ ":imgui_headers" ]
Expand Down

0 comments on commit 88b37b9

Please sign in to comment.