Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shanoir-issue#2372: add endpoint to remove SR from viewer #2403

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

pierrehenri-dauvergne
Copy link
Collaborator

@pierrehenri-dauvergne pierrehenri-dauvergne commented Sep 10, 2024

How to test:
Open DICOM in ohif viewer
Make a measurement
Open right-side panel
Click on "Create report":
image

At this point, a new dataset is visible in solr:
image

In the left-side panel, a new serie appears:
image

Click on the trash-bin icon, a pop-up appears, click 'yes' to delete the measurement:
image

The solr dataset is deleted.

@pierrehenri-dauvergne
Copy link
Collaborator Author

An issue is opened in the OHIF git page for this (missing Authorization header), this feature won't work until the issue is fixed:
OHIF/Viewers#4364

Copy link
Contributor

@michaelkain michaelkain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, code review looks good

@pierrehenri-dauvergne pierrehenri-dauvergne linked an issue Sep 11, 2024 that may be closed by this pull request
Copy link
Contributor

@michaelkain michaelkain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review is good now, I will test locally

@michaelkain
Copy link
Contributor

Hi Pierre-Henri,
I am testing and something is strange.
I created a measurement and deleted it (added Authorization to header and got a 200 http code).
Result: the measurement dataset is removed from Solr, good, but it remains in tree. And even when
I log out and log in again, it remains in the tree and I can see details. So, I would say the deletion is
only half done, see my screenshots (latest dataset in Solr and dataset details). With kind regards,
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ohif-viewer: delete measurement report not working
2 participants