feat(IdRegistry): fail transfer, recovery, changeRecovery when paused #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage after merging varunsrin/idr-transfer-recovery-changerec-pause-fail into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
horsefacts
deleted the
varunsrin/idr-transfer-recovery-changerec-pause-fail
branch
Hmac512
pushed a commit
to Hmac512/farcaster-contracts
that referenced
this pull request
Aug 2, 2023
Hmac512
pushed a commit
to Hmac512/farcaster-contracts
that referenced
this pull request
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If IdRegistry needs to be redeployed it is useful to have a way to freeze the old contract so that all state can be copied over to the new one. The
pausefunction previously allowed transfers, recoveries and changing the recovery address which meant that it could not be used to guarantee that state would not change.Change Summary
Revert transfer, changeRecoveryAddress and recover if the contract is paused.
Merge Checklist