Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: idregistry state cannot be frozen for a future upgrade #295

Closed
varunsrin opened this issue Jul 31, 2023 · 1 comment
Closed

bug: idregistry state cannot be frozen for a future upgrade #295

varunsrin opened this issue Jul 31, 2023 · 1 comment
Assignees
@varunsrin
Labels
bug Something isn't working

Comments

@varunsrin
Copy link
Member

What is the bug?
There is no way to freeze the state of IdRegistry, which is important for a safe upgrade in case a bug is discovered in the future. The closest function is pause, which does not prevent transfers or recoveries. Consider extending pause to freeze all state or add a new one-way method like deprecate which freezes the contract entirely.
@varunsrin varunsrin added the bug Something isn't working label Jul 31, 2023
@varunsrin varunsrin self-assigned this Jul 31, 2023
@horsefacts horsefacts mentioned this issue Aug 1, 2023
Merged
4 tasks
@horsefacts
Copy link
Collaborator

@varunsrin I think this was closed by #301 Anything remaining?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varunsrin varunsrin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@varunsrin @horsefacts