-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: The existing implementation doesn't support including another thrift file. This diff fixed it. The main change of this diff is in ``` tools/build_defs/fbcode_macros/build_defs/lib/thrift/patch.bzl ``` However, after this diff, we will need to enable `python_patch` for all included files, thus we have to enable it for all annotations. In the future we could potentially create `no_languages_deps` (similar to `no_plugin_deps` to improve the ergonomic). Reviewed By: thedavekwon Differential Revision: D64764838 fbshipit-source-id: 373539f6c4d1184ae2b2a1caacc2ec8717d6cfcc
- Loading branch information
1 parent
288dfaa
commit f9ff628
Showing
4 changed files
with
14 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,7 @@ | |
}} | ||
# @{{!}}generated | ||
from __future__ import annotations | ||
|
||
import typing | ||
import typing as _typing | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters