-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: If users have custom py3 namespace, we need to output file in the namespace path. e.g., if we have `namespace py3 foo.bar` * Before this diff, we output to `gen-python-patch/thrift_patch.py`, but this won't work with base_module. * After this diff, we output to `gen-python-patch/foo/bar/thrift_patch.py` and set base_module to "foo. Bar". Note: 1. If users don't have custom py3 namespace, we will create a default one that matches the file path of the thrift file to simplify the logic, so that later down the line we don't need special logic to handle py3_namespace == None. 2. Python foundation plans to get rid of base_module, but we won't wait for that. Reviewed By: ahilger Differential Revision: D64764839 fbshipit-source-id: 945578f3672d096be793e26e8882277ad19cd9c1
- Loading branch information
1 parent
74a8c31
commit 288dfaa
Showing
3 changed files
with
37 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters