fix status with image problem #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add fix for camera with new version
…essage when send photo and send message without image if with image it doesn't add trace of image to be send to try to understand why in some case the image is not send fix error in command again
| webcam = provided_webcam.config | ||
|
|
||
| if webcam is None: | ||
| self._logger.exception("Exception WebcamNotAbleToTakeSnapshotException(provided_webcam is None)") |
There was a problem hiding this comment.
logging.Logger.exception should only be called from an exception handler: https://docs.python.org/3/library/logging.html#logging.Logger.exception
| can_snapshot = snapshot_url is not None and snapshot_url != "http://" and snapshot_url != "" | ||
|
|
||
| if not can_snapshot: | ||
| self._logger.exception("Exception WebcamNotAbleToTakeSnapshotException("+webcam.name+")") |
There was a problem hiding this comment.
logging.Logger.exception should only be called from an exception handler: https://docs.python.org/3/library/logging.html#logging.Logger.exception
octoprint_telegram/__init__.py
Outdated
| @@ -2573,9 +2683,12 @@ def getUpdateMsgId(self, id): | |||
| del self.updateMessageID[id] | |||
| return uMsgID | |||
|
|
|||
| def take_image(self, snapshot_url=""): | |||
| def take_image(self, snapshot_url="",cam_conf=0): | |||
There was a problem hiding this comment.
If the parameter represents an object, it should be initialized as None, not 0.
| @@ -2684,12 +2804,15 @@ def calculate_ETA(self, printTime=0): | |||
|
|
|||
| return strtime + strdate | |||
|
|
|||
| def create_gif_new(self, chatID, sec=7, multicam_prof=0): | |||
| def create_gif_new(self, chatID, sec=7, multicam_prof=0,cam_conf=0): | |||
There was a problem hiding this comment.
If the parameter represents an object, it should be initialized as None, not 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the status with image
add pre and post command delay
add again command