Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prerequisites for practice exercises #1942

Merged
merged 5 commits into from
Oct 29, 2022
Merged

Add prerequisites for practice exercises #1942

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bc6b0aa
Add prerequisites for 'Perfect Numbers'
TomPradat Oct 9, 2022
f2f200a
Add prerequisites for 'Luhn'
TomPradat Oct 9, 2022
0f67d36
Add prerequisites for exercise 'grains'
TomPradat Oct 16, 2022
64a461d
Add prerequisites for exercise 'pythagorean-triplet'
TomPradat Oct 19, 2022
fda096f
Add prerequisites for exercise Palindrome products
TomPradat Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,13 @@
"name": "Perfect Numbers",
"uuid": "c6691fd2-e10d-47df-acbf-3adeac5a2f89",
"practices": [],
"prerequisites": [],
"prerequisites": [
"numbers",
"arrays",
"conditionals",
"errors",
"for-loops"
],
Comment on lines +706 to +712
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/perfect-numbers/solutions/TomPradat

"difficulty": 3,
"topics": ["arrays", "conditionals", "loops", "integers", "math"]
},
Expand All @@ -721,7 +727,7 @@
"name": "Luhn",
"uuid": "28872cc9-f1ef-487f-9a79-6bf7983148bf",
"practices": [],
"prerequisites": [],
"prerequisites": ["numbers", "conditionals", "array-transformations"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/luhn/solutions/TomPradat

I haven't added "array-analysis" despite the fact that I personally use Array#some as it does not seem necessary (as we can see in other community solutions)

"difficulty": 4,
"topics": ["conditionals", "loops", "integers", "strings"]
},
Expand All @@ -739,7 +745,7 @@
"name": "Grains",
"uuid": "d003975a-9045-4f03-9ad9-c15db584dc13",
"practices": [],
"prerequisites": [],
"prerequisites": ["conditionals", "errors", "numbers", "math"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/grains/solutions/TomPradat

I'm not sure about errors, I added it because you need to throw errors in the exercise. Though that's the case of many practice exercises, and the errors concept is very advanced in the hierarchy, what do you think ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the right choice because you must understand how errors work. We can re-evaluate later.

"difficulty": 5,
"topics": ["loops", "integers"]
},
Expand All @@ -748,7 +754,14 @@
"name": "Pythagorean Triplet",
"uuid": "394755a3-c743-4b85-b9b8-387907f4e32d",
"practices": [],
"prerequisites": [],
"prerequisites": [
"classes",
"arrays",
"for-loops",
"numbers",
"math",
"conditionals"
],
Comment on lines +757 to +764
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/pythagorean-triplet/solutions/TomPradat

By the way I see a lot of exercises like this one using classes which is a pretty high level concept in the JS track. Should we reevaluate the use of classes in this exercise ? Not add the classes as a prerequisites ? Leave it as is ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good question. I think it's fine for now, we'll reevaluate together after if you want.

"difficulty": 5,
"topics": ["algorithms", "conditionals", "loops", "integers", "math"]
},
Expand All @@ -757,7 +770,15 @@
"name": "Palindrome Products",
"uuid": "f6799d10-0210-4c73-ac08-d5cac1a00ff3",
"practices": [],
"prerequisites": [],
"prerequisites": [
"classes",
"errors",
"strings",
"objects",
"for-loops",
"arrays",
"conditionals"
],
Comment on lines +773 to +781
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/palindrome-products/solutions/TomPradat

"difficulty": 7,
"topics": [
"algorithms",
Expand Down