Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prerequisites for practice exercises #1942

Merged
merged 5 commits into from
Oct 29, 2022

Conversation

TomPradat
Copy link
Contributor

@TomPradat TomPradat commented Oct 9, 2022

This is the last batch about #983

Could i have an hacktoberfest-accepted label please ? 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Dear TomPradat

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

Comment on lines +706 to +712
"prerequisites": [
"numbers",
"arrays",
"conditionals",
"errors",
"for-loops"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -721,7 +727,7 @@
"name": "Luhn",
"uuid": "28872cc9-f1ef-487f-9a79-6bf7983148bf",
"practices": [],
"prerequisites": [],
"prerequisites": ["numbers", "conditionals", "array-transformations"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/luhn/solutions/TomPradat

I haven't added "array-analysis" despite the fact that I personally use Array#some as it does not seem necessary (as we can see in other community solutions)

@TomPradat TomPradat changed the title Add prerequisites for 'Perfect Numbers' Add prerequisites for practice exercises Oct 9, 2022
@SleeplessByte SleeplessByte added the hacktoberfest-accepted Opt-in to hacktoberfest label Oct 10, 2022
@@ -739,7 +745,7 @@
"name": "Grains",
"uuid": "d003975a-9045-4f03-9ad9-c15db584dc13",
"practices": [],
"prerequisites": [],
"prerequisites": ["conditionals", "errors", "numbers", "math"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/grains/solutions/TomPradat

I'm not sure about errors, I added it because you need to throw errors in the exercise. Though that's the case of many practice exercises, and the errors concept is very advanced in the hierarchy, what do you think ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the right choice because you must understand how errors work. We can re-evaluate later.

Comment on lines +757 to +764
"prerequisites": [
"classes",
"arrays",
"for-loops",
"numbers",
"math",
"conditionals"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my solution : https://exercism.org/tracks/javascript/exercises/pythagorean-triplet/solutions/TomPradat

By the way I see a lot of exercises like this one using classes which is a pretty high level concept in the JS track. Should we reevaluate the use of classes in this exercise ? Not add the classes as a prerequisites ? Leave it as is ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good question. I think it's fine for now, we'll reevaluate together after if you want.

Comment on lines +773 to +781
"prerequisites": [
"classes",
"errors",
"strings",
"objects",
"for-loops",
"arrays",
"conditionals"
],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomPradat TomPradat marked this pull request as ready for review October 23, 2022 20:45
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@SleeplessByte SleeplessByte merged commit 6b57d1f into exercism:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants