-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prerequisites for practice exercises #1942
Add prerequisites for practice exercises #1942
Conversation
Dear TomPradatThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
"prerequisites": [ | ||
"numbers", | ||
"arrays", | ||
"conditionals", | ||
"errors", | ||
"for-loops" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/perfect-numbers/solutions/TomPradat
@@ -721,7 +727,7 @@ | |||
"name": "Luhn", | |||
"uuid": "28872cc9-f1ef-487f-9a79-6bf7983148bf", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["numbers", "conditionals", "array-transformations"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/luhn/solutions/TomPradat
I haven't added "array-analysis" despite the fact that I personally use Array#some
as it does not seem necessary (as we can see in other community solutions)
@@ -739,7 +745,7 @@ | |||
"name": "Grains", | |||
"uuid": "d003975a-9045-4f03-9ad9-c15db584dc13", | |||
"practices": [], | |||
"prerequisites": [], | |||
"prerequisites": ["conditionals", "errors", "numbers", "math"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/grains/solutions/TomPradat
I'm not sure about errors, I added it because you need to throw errors in the exercise. Though that's the case of many practice exercises, and the errors concept is very advanced in the hierarchy, what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the right choice because you must understand how errors work. We can re-evaluate later.
"prerequisites": [ | ||
"classes", | ||
"arrays", | ||
"for-loops", | ||
"numbers", | ||
"math", | ||
"conditionals" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/pythagorean-triplet/solutions/TomPradat
By the way I see a lot of exercises like this one using classes which is a pretty high level concept in the JS track. Should we reevaluate the use of classes in this exercise ? Not add the classes
as a prerequisites ? Leave it as is ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good question. I think it's fine for now, we'll reevaluate together after if you want.
"prerequisites": [ | ||
"classes", | ||
"errors", | ||
"strings", | ||
"objects", | ||
"for-loops", | ||
"arrays", | ||
"conditionals" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my solution : https://exercism.org/tracks/javascript/exercises/palindrome-products/solutions/TomPradat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This is the last batch about #983
Could i have an hacktoberfest-accepted label please ? 🙏