Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resistor-color #164

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Add resistor-color #164

merged 2 commits into from
Jul 25, 2024

Conversation

keiravillekode
Copy link
Contributor

No description provided.

@keiravillekode
Copy link
Contributor Author

We could make the return type Maybe Int . The canonical tests for this exercise don't have an error cases as it supposed to be an easy exercise. So I haven't made that change.

isberg
isberg approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@isberg isberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A return type of Maybe Int seems better, but I wont mind that being a separate PR.

@keiravillekode
Copy link
Contributor Author

Done. This will boost the difficulty of resistor-color-duo / resistor-color-trio, and I like to keep the resistor-color exercises together, so I have boosted the resistor-color difficulty.

isberg
isberg approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@isberg isberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible alternative would be to have a function Color -> Fin 10 instead of String -> Maybe (Fin 10). Not sure which makes more sense fur this exercise.

@keiravillekode keiravillekode merged commit 7506846 into exercism:main Jul 25, 2024
1 check passed
@keiravillekode keiravillekode deleted the resistor-color branch July 25, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isberg isberg isberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keiravillekode @isberg