-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hash-table and package symcount #492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affonso-Gui
force-pushed
the
fix-hashtable-delete
branch
from
May 5, 2022 10:56
9c4ffb7
to
d689c00
Compare
I've updated the PR to use a different slot ( (deftest hash-table-count.11
(let ((table (make-hash-table)))
(setf (gethash 'x table) 1)
(values (hash-table-count table)
(progn
(remhash 'x table)
(hash-table-count table))))
1 0) |
ppc64le/debian:buster times out. Restarting.. |
confirmed that the test code works properly #510
|
k-okada
added a commit
that referenced
this pull request
Apr 18, 2024
* apply patches in dfsg (#511, https://salsa.debian.org/science-team/euslisp/-/tree/debian/9.29+dfsg-1/debian/patches?ref_type=tags) * fix rotate-vertices when an axis input is float-vector (#504) * load proper packages(g/x/gl) for full program path, this enables gdb works correctly (#495) * fix infinite loops when hash-table has no empty members (#492)
k-okada
added a commit
that referenced
this pull request
Apr 18, 2024
* apply patches in dfsg (#511, #482, https://salsa.debian.org/science-team/euslisp/-/tree/debian/9.29+dfsg-1/debian/patches?ref_type=tags) * fix rotate-vertices when an axis input is float-vector (#504) * load proper packages(g/x/gl) for full program path, this enables gdb works correctly (#495) * fix infinite loops when hash-table has no empty members (#492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current implementation euslisp's hash tables only keep count of its active members.
This allows for the hash-table to end up cluttered by deleted members, causing problems such as #405.
The same behavior is seen in packages' internal and external vectors, which are implemented to act as hash tables.
In this PR we solve this by keeping count of the used members (active + deleted) instead.