[WIP] Avoid infinite loop when hash-table has no empty members #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Infinite loops when hash-table has no empty members
Code to reproduce:
Why it happens:
del
symbols:find
method loops until it finds an empty member, which in this case does not existSolution:
After all elements are iterated in the
:find
method, return the first available slot (del symbol). If there are no available slots, raise an error reporting that the hash-table is full.Thanks to @ikeshou for finding the bug!