Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDC #585

Merged
merged 6 commits into from
Oct 9, 2020
Merged

CDC #585

merged 6 commits into from
Oct 9, 2020

Conversation

gitr0n1n
Copy link
Contributor

@gitr0n1n gitr0n1n commented Oct 2, 2020

  • Add Recording Link

+ Add Recording Link
@gitr0n1n gitr0n1n added the content adding or changing current info label Oct 2, 2020
@gitr0n1n gitr0n1n added this to the Website modernization milestone Oct 2, 2020
@gitr0n1n gitr0n1n self-assigned this Oct 2, 2020
@netlify
Copy link

netlify bot commented Oct 2, 2020

Deploy preview for ethereumclassic ready!

Built with commit 2e6ca9a

https://deploy-preview-585--ethereumclassic.netlify.app

+ Call results
@TheEnthusiasticAs TheEnthusiasticAs removed the request for review from realcodywburns October 4, 2020 15:04
+ Notes: Update conclusion of CDC 15
Copy link
Member

@developerkevin developerkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM. The only thing I ask you change is labeling this a "Core Dev Call." A CDC historically involves the status changes of an ECIP, not just a discussion. I believe "ECIP-1049 Keccak 256 Breakout Session" is the right way to label this call. Also, during CDC we coordinate with dev teams, groups, and the hard fork coordinator.

I'm for changing it to what I mentioned above or "Keccak Informational Breakout Session" instead of mislabeling it a Core Devs Call. We don't want to confuse the audience afterall.

@gitr0n1n
Copy link
Contributor Author

gitr0n1n commented Oct 7, 2020

Everything LGTM. The only thing I ask you change is labeling this a "Core Dev Call." A CDC historically involves the status changes of an ECIP, not just a discussion. I believe "ECIP-1049 Keccak 256 Breakout Session" is the right way to label this call. Also, during CDC we coordinate with dev teams, groups, and the hard fork coordinator.

I'm for changing it to what I mentioned above or "Keccak Informational Breakout Session" instead of mislabeling it a Core Devs Call. We don't want to confuse the audience afterall.

@developerkevin Please review the Agenda of the meeting and the Conclusion. This was certainly a CDC call on 1049 with a goal of finding rough consensus, which was not acheived at the current moment due to the many concerns brought up and the unknowns of the proposal. You can review the Agenda and the Conclusion to the call here:
ethereumclassic/ECIPs#382 (comment)

@gitr0n1n gitr0n1n dismissed developerkevin’s stale review October 7, 2020 22:00

The Agenda and Conclusion of the meeting addresses this concern.

Copy link
Member

@developerkevin developerkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ridiculous. Adding a line in the agenda saying "to gather rough consensus" just to "fit" into the criteria of a real "ETC Core Devs Call" after you've already submitted the PR, is disingenuous. This was not a "ETC Core Devs Call" period. full stop. Adding that line after I mentioned some criteria is insincere to the audience. This was not to measure "Rough Consensus" but to measure sentiment. Core Devs Calls are important calls that must be coordinated with each team, the hardfork coordinator, and focus on changing an ECIP to a new status.

Please remove line 8's "ETC Core Devs Call 15" and replace with "ECIP-1049 Keccak Breakout Session." This is more genuine and appropriate.

@gitr0n1n gitr0n1n dismissed developerkevin’s stale review October 8, 2020 21:48

Not applicable to the PR.

@developerkevin developerkevin self-requested a review October 8, 2020 22:33
Copy link
Member

@developerkevin developerkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I don't believe this was an "honest" ETC Core Devs Call, I will approve this pull request to add the audio/video.

@gitr0n1n gitr0n1n merged commit c1b8a52 into ethereumclassic:master Oct 9, 2020
@gitr0n1n gitr0n1n deleted the CDC branch October 9, 2020 02:43
@stevanlohja
Copy link
Contributor

stevanlohja commented Oct 9, 2020

I thought it was a great educational call of the ones skeptical of Keccak-256 change. Keccak-256 folks were given the spotlight and answered many questions that I felt answers were well substantiated.

@gitr0n1n
Copy link
Contributor Author

gitr0n1n commented Oct 10, 2020

I thought it was a great educational call of the ones skeptical of Keccak-256 change. Keccak-256 folks were given the spotlight and answered many questions that I felt answers were well substantiated.

Yes this was a high value Ethereum Classic Core Developers Call. Both the proponents and opponents had a detailed and educational discussion related to ECIP-1049. People vocalized their pleasure with the call and the calls conclusion in the #general chat. The only complaints came from two proponents of the proposal that wanted to rush ECIP-1049 through the process without any technical review (Donald and Kevin). Both of these people did not attend the call, they are the noise and not the signal.

Many of the questions presented by the opposition to the proposal lead the propoent faction to the realization that the proposal was not ready for Accepted status review. The proponents of ECIP-1049, ETC Coop, suggested the Delay of the proposal's review to allow them time to address the unknowns discussed. An additional concern was brought up by ETC Labs about a lack of of rough consensus and the potential for a fork at this moment.

As the moderator of the call, it was wonderful to hear the community discuss these issues in a profesisonal manner. It was a pleasure to host my first Core Developers Call and to have the Ethereum Classic development community embrace the call with such enthusiasm. I thank the proposal's author, all core development teams, and the mining developers for attending the Ethereum Classic Core Developers Call 15.
https://vimeo.com/464336957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content adding or changing current info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants