Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested parsers on MessageProducer level (v4) #2087

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow nested parsers on MessageProducer level (v4) #2087

wants to merge 2 commits into from

Commits on Sep 9, 2024

  1. Nested Parsers: Architectures proposal... 

    * Resolver will be passed to resolve method instead of parser returning
  a template.
* Parsing log message is returning an error which is defined by each
  type implementing LogMessage trait.
* Types with no errors sets the error to infallible for compiler
  optimizations.
* This approach enables saving parsing errors.
* Nested errors are ignored for now
    @AmmarAbouZor
    AmmarAbouZor committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d99005f View commit details
    Browse the repository at this point in the history

  2. Nested Parsers: Separate parsing in sessions and CLI 

    * Sessions needs to keep track on errors but indexer CLI doesn't need
  that for now.
* Each part should responsible of how errors for parsing log messages
  should be handled.
* Added reminder for handling resolver in indexer CLI.
    @AmmarAbouZor
    AmmarAbouZor committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1b3abb0 View commit details
    Browse the repository at this point in the history