Allow nested parsers on MessageProducer level (v4) #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolver will be passed to resolve method instead of parser returning a template. * Parsing log message is returning an error which is defined by each type implementing LogMessage trait. * Types with no errors sets the error to infallible for compiler optimizations. * This approach enables saving parsing errors. * Nested errors are ignored for now
* Sessions needs to keep track on errors but indexer CLI doesn't need that for now. * Each part should responsible of how errors for parsing log messages should be handled. * Added reminder for handling resolver in indexer CLI.
AmmarAbouZor
force-pushed
the
nested_parsers
branch
from
2c699c8
to
1b3abb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isn't for to be merged. It's a suggestion in the scope of work on #2073, #2078 and #2084
It provides the basic implementation for #2071 on parser level.
ParseRestResolverimplemented to provide methods to parse a given chunks of bytes with a hint about how to parse those bytes.LogMessagedoesn't implement Display anymore. Instead, it has the methodtry_resolve(&self, resolver: Option<&mut ParseRestResolver>) -> Result<impl Display, ...>to try to parse the message using the provided resolver if possible and returning an error to express the case when parsing fails.ParseLogMsgErroris defined with methods to parse the messages lossy (replace none-parsed bytes with their byte representation), besides the severity of the error and an error message to be used to collect the errors for proper error handling of parse log messages (as mentions in Consider Errors while parsing messages payload #2071)LogMessagehas and associated error type which implement ParseLogMsgError, giving a chance for parser which never fails to provide Infallible Error type, to tell the compiler that this types will never error for compile time optimizations. Parser that can fail can use the structGeneralParseLogErrorwhich implements the traitParseLogMsgError.