make Lowercase DynamicAnimatioReplacer folder load #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….cpp DynamicAnimationReplacer allows it folder to be lowercase which means a few DAR animation mods has that folder lower cased, and therefor wouldn't be loaded. however this problem could be compounded by using something like mo2 which makes a virtual directory, and since windows is case insensitive by default, if it finds the lower case folder first it will put all DynamicAnimationReplacer animations into a lowercase folder. making them all unable to be loaded. a better solution would probably be to lowercase a_path and then find, but im still very new to c++ so thats beyond me for now.
|
Thanks! I've opted to do it case insensitively right away (in a few more places too) instead of merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicAnimationReplacer allows it folder to be lowercase which means a few DAR animation mods has that folder lower cased, and due to StripReplacerPath in parsing not accounting for this, wouldn't be loaded. to fix this i simply added a extra check for lowercase following the pattern of the pervious checks.
it might be better to lowercase the a_path string and then find. so like default windows it will be case insensitive.
same with directoryPathStr in ReloadConfig in ReplacerMods. but i barley have any experience with c++, and string_view did not seem to have a easy function or the like to lower case it, so i leave that to someone else. that knows c++ and this code better.
this might seem like a small problem, since its rare for Animation mod to use a lowercase dynamicanimationreplacer folder, but since windows is by default case insensitive, so if the first animation mod you install uses lowercase all subsequent mods files will also be place in the lowercase folder. or in case of using something like mo2 with a virtual directory, if it loads a lowercase folder first same problem.