-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Authentication and Access Control Via OAuth and Team Membership #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not my formal review, I just found a typo and figured I'd provide a heads-up right away instead of waiting till the end.
Can we expand this from enf-engineering to enf-employees? The performance benchmark data typically has broader interest within the organization, beyond just the engineering team. |
Short answer is not at this time, because not all enf employees are on github, and we do not have a team that includes all employees. To fix this we could to add google as another oauth provider, and I can open an issue to track that. In addition, I will add the team membership to the env configuration file. This will make it easier to change the team that controls access. |
Added HTTP API using |
Added logic to authenticate against GitHub, and then check membership in engineering team for access control.