Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Chicken-Dance OAuth PR #97

Closed
ericpassmore opened this issue Apr 15, 2024 · 2 comments
Closed

Review Chicken-Dance OAuth PR #97

ericpassmore opened this issue Apr 15, 2024 · 2 comments
Assignees

Comments

@ericpassmore
Copy link
Contributor

Review PR eosnetworkfoundation/chicken-dance#96

@ericpassmore
Copy link
Contributor Author

Can I get an approval on the PR? In addition to resolving comments, made changes since last review

  1. added HTTP API authentication via Authenticate header
  2. allow multiple teams for access control
  3. more secure check authentication and access on every API request.

@kj4ezj
Copy link
Contributor

kj4ezj commented Jun 6, 2024

Approved and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants