Don't lock pull request discussions after merge #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #963 we introduced a CLA bot. By default, the package we used for that locks discussions on PRs after they are merged, limiting them to collaborators. The intent here is so that external contributors cannot revoke their CLA after the fact. I've been finding it pretty annoying to have the discussions locked even as a collaborator (e.g I can't react to messages). This also limits the potential for external contributors to point out bugs or issues in PRs down the line, which isn't ideal. I've changed the setting so that PRs aren't locked. I don't think the issue around contributors changing their comments after the fact should be a big deal given than we're storing that signature somewhere external.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #963 we introduced a CLA bot. By default, the package we used for that locks discussions on PRs
after they are merged, limiting them to collaborators.
The intent here is so that external contributors cannot revoke their CLA after the fact.
I've been finding it pretty annoying to have the discussions locked even as a collaborator (e.g I
can't react to messages). This also limits the potential for external contributors to point out bugs
or issues in PRs down the line, which isn't ideal.
I've changed the setting so that PRs aren't locked. I don't think the issue around contributors
changing their comments after the fact should be a big deal given than we're storing that signature
somewhere external.