Skip to content

Commit

Permalink
Don't lock pull request discussions after merge (#996)
Browse files Browse the repository at this point in the history
In #963 we introduced a CLA bot. By default, the package we used for that locks discussions on PRs
after they are merged, limiting them to collaborators.

The intent here is so that external contributors cannot revoke their CLA after the fact.

I've been finding it pretty annoying to have the discussions locked even as a collaborator (e.g I
can't react to messages). This also limits the potential for external contributors to point out bugs
or issues in PRs down the line, which isn't ideal.

I've changed the setting so that PRs aren't locked. I don't think the issue around contributors
changing their comments after the fact should be a big deal given than we're storing that signature
somewhere external.
  • Loading branch information
HCastano authored Aug 12, 2024
1 parent 142648d commit 5b0eb20
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/cla.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,4 @@ jobs:
exemptRepoOrgMembers: true
remote-organization-name: entropyxyz
remote-repository-name: .github
lock-pullrequest-aftermerge: false

0 comments on commit 5b0eb20

Please sign in to comment.