Drop support for Python versions earlier than 3.8 #1773
Conversation
| @@ -276,13 +276,6 @@ def get_long_description(): | |||
| Operating System :: POSIX :: Linux | |||
| Programming Language :: Python | |||
| Programming Language :: Python :: 3 | |||
| Programming Language :: Python :: 3.6 | |||
There was a problem hiding this comment.
Removing these classifiers - they're a pain to maintain and provide little value. Note that we do have a python_requires keyword below giving the minimum supported version of Python.
|
Hmm. A slightly odd failure on Python 3.13 / Windows: |
Looks like this might be the cause: python/cpython#115582 |
|
I'm not sure what to do about the Windows failure. It should be fixed as soon as Python 3.13.0a5 is released and is available for use by the |
3.13.0-alpha.4 has a bug that prevents Traits from compiling on Windows, so until alpha.5 is released, we use alpha.3.
|
@corranwebster I think this is ready for review. I've pinned the Python 3.13 version being used for the core tests; we'll need to remove that pin at some point. I'll need to adjust the PR expected checks to remove the 3.7 versions; I'll do that just before merging. |
This PR fixes some compiler warnings that I noticed in the failed Windows build in PR #1773. There are two classes of fixes: - Fix occurrences of `int` used to represent the size of a tuple / list / dict. Those should be `Py_ssize_t` - Fix two functions that treat a mask as having type `int`, when it should be `unsigned int`. All the actual masks used have type `unsigned int`. The warnings themselves are relatively harmless, but silencing them gives us a better chance of noticing warnings that we _should_ be taking notice of. The PR also adds a `-v` flag to the `pip install` commands that install Traits, so that compiler warnings will always be visible in the build log. Without the `-v`, we only get to see the warnings for failed builds.
This PR drops support for Python versions older than 3.8.