Fix some compiler warnings #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some compiler warnings that I noticed in the failed Windows build in PR #1773. There are two classes of fixes:
intused to represent the size of a tuple / list / dict. Those should bePy_ssize_tint, when it should beunsigned int. All the actual masks used have typeunsigned int.The warnings themselves are relatively harmless, but silencing them gives us a better chance of noticing warnings that we should be taking notice of.
The PR also adds a
-vflag to thepip installcommands that install Traits, so that compiler warnings will always be visible in the build log. Without the-v, we only get to see the warnings for failed builds.