Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registration tracking events for .eth and TLD (.box) funnel #840
Add registration tracking events for .eth and TLD (.box) funnel #840
Changes from 3 commits
9e7f8e5
ec53030
faa5383
e7e4e33
7043e84
fdcfeab
33be2fe
5a7ceca
95adbe7
e751725
eb52980
7ad1666
79d9b4b
d245e6b
eb690f3
8510aca
a25cbdf
7615aa6
78eb780
8f0f4ac
680f8bc
ab690fe
1d92628
b79df4f
ab526e0
740fafc
4884d4d
34d39ee
ad01f0b
7b2e76b
80525bc
68edbb1
62733f4
7efbc80
167aa22
5e876a8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's 2 register_started events. Can you double check if both are needed? This is why I suggested that we clear the events variable and check if the event has been called multiple times in registerName.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've analyzed the flow and determined the following:
If a user completes a commit transaction, the
registerTx
variable will beundefined
.The
makeRegisterNameFlow
function will be called.If the user refreshes the page, the
registerTx
variable will have a value, and theshowRegisterTransaction
function will be called.