Add registration tracking events for .eth and TLD (.box) funnel #840
Conversation
Deploying ens-app-v3 with
|
| Latest commit: |
78eb780
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca6bf95b.ens-app-v3.pages.dev |
| Branch Preview URL: | https://feat-fet-1177-add-registrati.ens-app-v3.pages.dev |
src/components/@molecules/TransactionDialogManager/stage/TransactionStageModal.tsx
Outdated
Show resolved
Hide resolved
…pened and finish wallet opened tracking events
nhohb
changed the title
There was a problem hiding this comment.
2 tests to add:
- e2e/specs/stateful/box.spec.ts: Add a new file that follows the dot box registration and fires the tracking events.
- e2e/specs/stateless/registerName [line 160] add a check that search_selected_eth is not fired from this search input.
Also. I know we haven't done this a lot but the registerName tests are starting to get really big so can you wrap your expect code with test.step('should fire tracking event: ', () => {...}?
| customProperties: { name: text }, | ||
| }) | ||
| } | ||
|
|
||
| const path = getRouteForSearchItem({ address, chainId, queryClient, selectedItem }) |
There was a problem hiding this comment.
If directing to .box registration page, path should be /dotbox/{name}. If directing to .eth registration page, path should be /register/{name}. Use this to fire the correct search_selected_[eth|box] event.
There was a problem hiding this comment.
@storywithoutend
I've implemented your suggestion, but I'm encountering an issue. When a user enters a keyword and immediately presses Enter, the path always resolves to /profile/{name} instead of /register/{name}.
I believe the ownerData variable is undefined because getCachedQueryData isn't returning data in time.
To address this, I've added a waitForTimeout in e2e/specs/stateless/registerName.spec.ts and included a comment explaining the reason.
Please review these changes and let me know if you have any further feedback.
| @@ -140,6 +142,8 @@ const Transactions = ({ registrationData, name, callback, onStart }: Props) => { | |||
| autoClose: true, | |||
| resumeLink: `/register/${name}`, | |||
| }) | |||
|
|
|||
| trackEvent({ eventName: 'register_started' }) | |||
| } | |||
There was a problem hiding this comment.
There's 2 register_started events. Can you double check if both are needed? This is why I suggested that we clear the events variable and check if the event has been called multiple times in registerName.spec.ts
There was a problem hiding this comment.
I've analyzed the flow and determined the following:
-
If a user completes a commit transaction, the
registerTxvariable will beundefined.
ThemakeRegisterNameFlowfunction will be called. -
If the user refreshes the page, the
registerTxvariable will have a value, and theshowRegisterTransactionfunction will be called.
Only want to fire this event if the name is available by reading path variable
…se waitFor() instead of waitForTimeout()
…-1177-add-registration-tracking-events
e2e/specs/stateless/box.spec.ts
Outdated
| }) | ||
|
|
||
| const events: string[] = [] | ||
| page.on('console', (msg) => { |
There was a problem hiding this comment.
Can we turn this into a fixture? I think it will be useful to use in the future.
src/utils/analytics.ts
Outdated
| const referrer = getUtm() | ||
|
|
||
| const props = referrer ? { ...customProperties, referrer } : customProperties |
There was a problem hiding this comment.
I don't think we need referrer ? {} : {}, we can just pass { ...customProperties, referrer}
…ub.com:ensdomains/ens-app-v3 into feat/FET-1177-add-registration-tracking-events
|
No description provided.