Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to node 20 #1074

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Update to node 20 #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8de6bd8
update to node 20
simonihmig Jan 7, 2024
8838b6b
Update ci.yml to use default npm version
simonihmig Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request:

env:
NODE_VERSION: 14
NODE_VERSION: 20
PERCY_PARALLEL_NONCE: ${{ github.run_id }}-${{ github.run_number }}
PERCY_PARALLEL_TOTAL: 1

Expand All @@ -28,16 +28,12 @@ jobs:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}

- name: Update npm
run: npm i -g npm@7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this anymore, node 20 ships with npm v10.


- name: Install dependencies
run: npm ci

- name: Lint
run: npm run lint


test-app:
name: Test app
runs-on: ubuntu-latest
Expand All @@ -52,9 +48,6 @@ jobs:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}

- name: Update npm
run: npm i -g npm@7

- name: Install dependencies
run: npm ci

Expand All @@ -65,7 +58,6 @@ jobs:
PERCY_PARALLEL_TOTAL: ${{ env.PERCY_PARALLEL_TOTAL }}
PERCY_TOKEN: c08aaada222e9cb103a28b98e94d71ff8baaddb5a548237432d900f1d4a9ec27


lighthouse-ci:
name: Run Lighthouse
runs-on: ubuntu-latest
Expand All @@ -82,9 +74,6 @@ jobs:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}

- name: Update npm
run: npm i -g npm@7

- name: Install dependencies
run: npm ci

Expand Down
5 changes: 2 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"webpack": "^5.76.0"
},
"engines": {
"node": "12.* || 14.* || >= 16"
"node": ">= 20"
},
"ember": {
"edition": "octane"
Expand All @@ -108,7 +108,6 @@
"algoliasearch"
],
"volta": {
"node": "14.16.0",
"npm": "8.5.3"
"node": "20.10.0"
}
}
Loading