Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 20 #1074

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Update to node 20 #1074

merged 2 commits into from
Jan 8, 2024

Conversation

simonihmig
Copy link
Contributor

Node 20 is the active LTS.

Copy link

netlify bot commented Jan 7, 2024

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 8838b6b
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/659b26b56eaf950008e732f3
😎 Deploy Preview https://deploy-preview-1074--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@simonihmig simonihmig marked this pull request as ready for review January 7, 2024 21:48
@@ -28,16 +28,12 @@ jobs:
cache: 'npm'
node-version: ${{ env.NODE_VERSION }}

- name: Update npm
run: npm i -g npm@7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this anymore, node 20 ships with npm v10.

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@mansona mansona merged commit 7d510ad into ember-learn:main Jan 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants