Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/decorator routing #19

Merged
merged 5 commits into from
Feb 27, 2020
Merged

Feature/decorator routing #19

merged 5 commits into from
Feb 27, 2020

Conversation

DominikHorn
Copy link
Contributor

@DominikHorn DominikHorn commented Feb 27, 2020 •
edited
Loading

Core idea was to replace the rather imperative routing code with declarative decorator-driven design. Turns out this is not ideal:

  • Route conflicts between components are not easily detectable
  • Linking between components requires one central route container/manager anyways
  • Since Root components with an @routed decorator are not required/imported by any other files, they won't show up. This necessitates ugly manual require()/import() statements in at least one file.

All surviving changes from this ticket aim to enhance the routing code/prepare it for future code modularization steps

closing #13

@DominikHorn DominikHorn self-assigned this Feb 27, 2020
@DominikHorn DominikHorn linked an issue Feb 27, 2020 that may be closed by this pull request
Explore routing via decorators #13
Open
@DominikHorn DominikHorn added the enhancement Enhancement of existing code/features label Feb 27, 2020
@toschmidt toschmidt merged commit 96e3a62 into development Feb 27, 2020
@toschmidt toschmidt deleted the feature/decorator-routing branch February 27, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toschmidt toschmidt toschmidt approved these changes

@FabianWildgrube FabianWildgrube Awaiting requested review from FabianWildgrube

@AlexanderZellner AlexanderZellner Awaiting requested review from AlexanderZellner

@maxammann maxammann Awaiting requested review from maxammann

@ricffb ricffb Awaiting requested review from ricffb

@SimonKostin98 SimonKostin98 Awaiting requested review from SimonKostin98

Assignees

@DominikHorn DominikHorn

Labels
enhancement Enhancement of existing code/features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore routing via decorators
2 participants
@DominikHorn @toschmidt