Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore routing via decorators #13

Open
DominikHorn opened this issue Feb 26, 2020 · 0 comments · Fixed by #19
Open

Explore routing via decorators #13

DominikHorn opened this issue Feb 26, 2020 · 0 comments · Fixed by #19
Assignees
@DominikHorn
Labels
enhancement Enhancement of existing code/features

Comments

@DominikHorn
Copy link
Contributor

Instead of manually declaring routes in a separate file, decorate the main page component:

https://www.typescriptlang.org/docs/handbook/decorators.html

Credit for the idea to @schmitob
@DominikHorn DominikHorn added the enhancement Enhancement of existing code/features label Feb 26, 2020
@DominikHorn DominikHorn self-assigned this Feb 26, 2020
DominikHorn added a commit that referenced this issue Feb 26, 2020
@DominikHorn
implement basic @routed anotation idea #13
932592e
DominikHorn added a commit that referenced this issue Feb 26, 2020
@DominikHorn
implement basic @routed annotation idea #13
97393f6
DominikHorn added a commit that referenced this issue Feb 27, 2020
@DominikHorn
upgrade routing: use hashmap instead of array for storing routes #13
d62da94
DominikHorn added a commit that referenced this issue Feb 27, 2020
@DominikHorn
implement basic @routed annotation idea #13
17d36c9
DominikHorn added a commit that referenced this issue Feb 27, 2020
@DominikHorn
upgrade routing: use hashmap instead of array for storing routes #13
b242ef1
DominikHorn added a commit that referenced this issue Feb 27, 2020
@DominikHorn
move routing util code to separate package #13
25eff2a
DominikHorn added a commit that referenced this issue Feb 27, 2020
@DominikHorn
revert to less declarative routing #13
ea58e75 
* avoid having to forcefully require components
* avoid namespace/path collisions more elegantly
* make ordering pages (regarding navbar) easily feasable
DominikHorn added a commit that referenced this issue Feb 27, 2020
@DominikHorn
remove routing package and reimplement old routing style #13
fcc1d4d
@DominikHorn DominikHorn mentioned this issue Feb 27, 2020
Merged
@DominikHorn DominikHorn linked a pull request Feb 27, 2020 that will close this issue
Feature/decorator routing #19
Merged
@DominikHorn DominikHorn changed the title Try to implement routing via Decorators Explore routing via decorators Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominikHorn DominikHorn

Labels
enhancement Enhancement of existing code/features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/decorator routing elite-se/elite-se.webpage
1 participant
@DominikHorn