Assume schema rust definition #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add pub
oflatt
force-pushed
the
oflatt-input-schema-rust
branch
from
95427e5
to
9ad632f
Compare
ezrosent
reviewed
Feb 5, 2024
tree_inputs/src/schema.rs
Outdated
| BoolT, | ||
| UnitT, | ||
| /// Nested tuple types are not allowed. | ||
| TupleT(Vec<Rc<Type>>), |
There was a problem hiding this comment.
If nested tuples aren't allowed, can we make them unrepresentable, as in:
pub enum BaseType { Int, Bool, Unit }
pub enum Type { Prim(BaseType), Tuple(Vec<BaseType>) }This way we also get to avoid boxing the tuple elements.
|
closing for now, will open a new PR for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.