Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume Schema- New Schema Solves Context with Assume #315

Merged
merged 18 commits into from
Feb 6, 2024

Conversation

oflatt
Copy link
Member

@oflatt oflatt commented Feb 2, 2024

Using assume nodes to create context is much cleaner
Also, tuple values are flat

@oflatt oflatt changed the title Input Schema- new schema based on shared Inputs to regions. Assume Schema- New Schema Solves Context with Assume Feb 3, 2024
tree_inputs/src/schema.egg Outdated Show resolved Hide resolved
@oflatt oflatt marked this pull request as ready for review February 6, 2024 16:16
@ezrosent ezrosent self-requested a review February 6, 2024 19:00
Copy link
Collaborator

@ezrosent ezrosent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(did a review over zoom and discussed this one. LGTM!)

@oflatt oflatt merged commit 1822b82 into main Feb 6, 2024
4 checks passed
@oflatt oflatt deleted the oflatt-input-schema branch February 6, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants