Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Open XL compiler warnings #7416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Open XL compiler warnings #7416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/optimizer/ValuePropagationCommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3295,7 +3295,7 @@ void OMR::ValuePropagation::transformRealTimeArrayCopy(TR_RealTimeArrayCopy *rtA
//create ifNodes
TR::Node *spineShiftNode = TR::Node::create(vcallNode, TR::iconst, 0, (int32_t)fe()->getArraySpineShift(elementSize));
TR::TreeTop *ifTree;
TR::Node *ifNode;
TR::Node *ifNode = nullptr;
Copy link
Contributor

@babsingh babsingh Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can it be initialized similar to the adjacent local variables? and why is ifTree not being initialized?

Suggested change
TR::Node *ifNode = nullptr;
TR::TreeTop *ifTree = NULL;
TR::Node *ifNode = NULL;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ValuePropagationCommon.cpp, there are many other uninitialized variables. Can you initialize all of them?

TR::Node *srcOff = NULL, *dstOff = NULL;
TR::Node *len = NULL;
TR::SymbolReference *child1Ref = NULL, *child2Ref = NULL;
Expand Down
Loading