Fix Open XL compiler warnings #7416
Conversation
|
@keithc-ca @0xdaryl I'm opening the file |
|
I believe the check only considers lines modified in this pull request, but I would support removing trailing whitespace from all lines. |
Changes along with the diagnostic flags: compiler/optimizer/ValuePropagationCommon.cpp [-Wsometimes-uninitialized] include_core/unix/zos/edcwccwi.h [-Wtrigraphs, removed ALL trailing whitespace] util/a2e/atoe.c [-Wwritable-strings] util/a2e/headers/stdio.h [-Wwritable-strings] Signed-off-by: Gaurav Chaudhari <[email protected]>
|
Removed all the trailing whitespace from |
|
jenkins build all |
| @@ -3295,7 +3295,7 @@ void OMR::ValuePropagation::transformRealTimeArrayCopy(TR_RealTimeArrayCopy *rtA | |||
| //create ifNodes | |||
| TR::Node *spineShiftNode = TR::Node::create(vcallNode, TR::iconst, 0, (int32_t)fe()->getArraySpineShift(elementSize)); | |||
| TR::TreeTop *ifTree; | |||
| TR::Node *ifNode; | |||
| TR::Node *ifNode = nullptr; | |||
There was a problem hiding this comment.
For consistency, can it be initialized similar to the adjacent local variables? and why is ifTree not being initialized?
| TR::Node *ifNode = nullptr; | |
| TR::TreeTop *ifTree = NULL; | |
| TR::Node *ifNode = NULL; |
There was a problem hiding this comment.
In ValuePropagationCommon.cpp, there are many other uninitialized variables. Can you initialize all of them?
Changes along with the diagnostic flags:
compiler/optimizer/ValuePropagationCommon.cpp [-Wsometimes-uninitialized]
include_core/unix/zos/edcwccwi.h [-Wtrigraphs]
util/a2e/atoe.c [-Wwritable-strings]
util/a2e/headers/stdio.h [-Wwritable-strings]