IMenuObjectInfo should use ImageDescriptor instead of Image. #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
use-imagedescriptor-for-menuobjectinfo
branch
from
cb518c4
to
9185b58
Compare
The image stored in the IMenuObjectInfo instances are used for the presentation. We should switch to ImageDescriptors, to avoid "Widget is disposed" exceptions when closing the editor. The getImage() method has been renamed to getImageDescriptor(). Where necessary, we use ImageDescriptor.createFromImage() to convert images to the correct type. Those images are slowly going to be transformed in ImageDescriptors in upcoming changes. When drawing those components, a temporary Image instance is created.
ptziegler
force-pushed
the
use-imagedescriptor-for-menuobjectinfo
branch
from
9185b58
to
4b4e872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image stored in the IMenuObjectInfo instances are used for the presentation. We should switch to ImageDescriptors, to avoid "Widget is disposed" exceptions when closing the editor.
The getImage() method has been renamed to getImageDescriptor(). Where necessary, we use ImageDescriptor.createFromImage() to convert images to the correct type. Those images are slowly going to be transformed in ImageDescriptors in upcoming changes.
When drawing those components, a temporary Image instance is created.