Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMenuObjectInfo should use ImageDescriptor instead of Image. #514

Merged
merged 1 commit into from
Jul 27, 2023
Merged

IMenuObjectInfo should use ImageDescriptor instead of Image. #514

merged 1 commit into from
Jul 27, 2023

Commits on Jul 25, 2023

  1. IMenuObjectInfo should use ImageDescriptor instead of Image. 

    The image stored in the IMenuObjectInfo instances are used for the
presentation. We should switch to ImageDescriptors, to avoid "Widget is
disposed" exceptions when closing the editor.

The getImage() method has been renamed to getImageDescriptor(). Where
necessary, we use ImageDescriptor.createFromImage() to convert images to
the correct type. Those images are slowly going to be transformed in
ImageDescriptors in upcoming changes.

When drawing those components, a temporary Image instance is created.
    @ptziegler
    ptziegler committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4b4e872 View commit details
    Browse the repository at this point in the history