-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if the fragment doesnot already have a name #2825
base: master
Are you sure you want to change the base?
Check if the fragment doesnot already have a name #2825
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2825 (2024-03-15T16:28:55Z) ⚙️ JKube E2E Tests (8298951289)
|
@amihalfa Welcome, Thanks a lot for contributing to Eclipse JKube 👍, In order to contribute to Eclipse, you would need to create an Eclipse Account and Sign Eclipse Contributor Agreement. Once you've created an eclipse account you would need to update your commit message with a
|
@amihalfa : Could you please add a unit test for this too? |
04e48b5
to
50f3cc5
Compare
Signed-off-by: amihalfa <[email protected]>
50f3cc5
to
fdec19c
Compare
@rohanKanojia To be honest, I don't know what to do for the integration test |
Deployment and Service get created with opinionated defaults before invoking NameEnricher, Maybe we can modify NameEnricher to use this value to differentiate whether the name inside the current resource is opinionated (generated by plugin) or is actually set by the user? |
Polite ping, is this being worked on? |
Let me pick this up and discuss internally with the team about what needs to be done |
Description
In the
NamingEnricher
, instead of overriding all the object names by the${jkube.enricher.jkube-name.name}
, only overrides name to every object which misses a name.Fixes #2823
Type of change
test, version modification, documentation, etc.)