Adapt tests to the new NameEnricher behaviour

eclipse-jkube · Mar 15, 2024 · 04e48b5 · 04e48b5
1 parent b082aab
commit 04e48b5
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/...t/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/NameEnricherTest.java b/...t/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/NameEnricherTest.java
@@ -118,7 +118,7 @@ void create_withAlreadyExistingName_shouldKeepExistingName() {
   }
 
   @Test
-  void create_withCustomNameAndAlreadyExistingName_shouldOverrideExistingName() {
+  void create_withCustomNameAndAlreadyExistingName_shouldKeepExistingName() {
     // Given
     klb = new KubernetesListBuilder();
     properties.put("jkube.enricher.jkube-name.name", "custom-name");
@@ -128,6 +128,20 @@ void create_withCustomNameAndAlreadyExistingName_shouldOverrideExistingName() {
     // Then
     assertThat(klb.build().getItems())
         .singleElement()
-        .hasFieldOrPropertyWithValue("metadata.name", "custom-name");
+        .hasFieldOrPropertyWithValue("metadata.name", "existing-name");
+  }
+
+  @Test
+  void create_withoutName_shouldSetGivenCustomName() {
+    // Given
+    klb = new KubernetesListBuilder();
+    properties.put("jkube.enricher.jkube-name.name", "custom-name");
+    // When
+    klb.addToItems(new ServiceBuilder().withNewMetadata().endMetadata().build());
+    new NameEnricher(context).create(PlatformMode.kubernetes, klb);
+    // Then
+    assertThat(klb.build().getItems())
+            .singleElement()
+            .hasFieldOrPropertyWithValue("metadata.name", "custom-name");
   }
 }