Sort by open bot PRs #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richpjames
force-pushed
the
sort-by-open-bot-prs
branch
2 times, most recently
from
38df894
to
562d103
Compare
richpjames
force-pushed
the
sort-by-open-bot-prs
branch
from
e0a035d
to
c9d2d92
Compare
added 6 commits
September 17, 2024 11:02
Previously we mapped the repo from its API format to the format we want in our JSON just before pushing into into our array. This meant we add to re-add properties that we just added to the repo again (eg Dependencies). Now we convert it from the API shape to our JSON shape then add the custom properties. This means we can make changes in getOpenPRsForRepo to add properties without having to update `mapRepoFromApiForStorage` too.
We will soon want to consume multiple values from this function so lets convert its return type to be an object in order to make it possible
User need to know how many of the open PRs are automated depdency updates. This column shows how many open PRs exist for a repo where the user login is either `renovate[bot]` or `dependabot[bot]`. This may need to be finetuned later.
By adding this we ensure screen readers can comprehend the table correctly
richpjames
force-pushed
the
sort-by-open-bot-prs
branch
from
c9d2d92
to
cdca047
Compare
danlivings-dxw
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks how many of the open PRs for a repo are made by either dependabot or renovate and adds a sortable column for these PRs
