Update E2Es

dxw · Sep 17, 2024 · cdca047 · cdca047
1 parent d303dc2
commit cdca047
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 7 deletions.
diff --git a/e2es/seedTestData.js b/e2es/seedTestData.js
@@ -2,7 +2,7 @@ import { copyFile, mkdir } from "fs/promises";
 
 export const createDestinationDirectory = async () => {
   console.info("Creating destination directory...");
-  await mkdir("./data");
+  await mkdir("./data", { recursive: true });
 };
 
 export const seedTestData = async () => {

diff --git a/e2es/testData/repos.json b/e2es/testData/repos.json
@@ -11,7 +11,7 @@
       "updatedAt": "2024-07-08T12:39:14Z",
       "language": "PHP",
       "topics": ["composer", "govpress", "packagist", "php"],
-      "openIssues": 0,
+      "openIssues": 10,
       "dependencies": [],
       "openPrCount": 0,
       "openBotPrCount": 0
@@ -28,8 +28,8 @@
       "topics": ["govpress", "wordpress-theme"],
       "openIssues": 1,
       "dependencies": [],
-      "openPrCount": 0,
-      "openBotPrCount": 1
+      "openPrCount": 20,
+      "openBotPrCount": 10
     },
     {
       "name": "php-missing",
@@ -43,7 +43,7 @@
       "topics": ["composer", "govpress", "packagist", "php"],
       "openIssues": 7,
       "dependencies": [],
-      "openPrCount": 2,
+      "openPrCount": 200,
       "openBotPrCount": 3
     }
   ]

diff --git a/e2es/towtruck.spec.js b/e2es/towtruck.spec.js
@@ -13,10 +13,62 @@ test("has dependency info", async ({ page, baseURL }) => {
     "Language",
     "Last Updated",
     "Open issues count",
-    "Open PRs count",
+    "Open PR count",
     "Dependencies",
   ];
   tableHeadings.forEach((heading) => {
-    page.getByRole("columnheader", { name: heading });
+    expect(page.getByRole("columnheader", { name: heading })).toBeTruthy();
   });
+
+  await testSortingForColumn(
+    {
+      name: "Open issues count",
+      topAscending: "govuk-blogs",
+      topDescending: "optionparser",
+    },
+    page
+  );
+
+  await testSortingForColumn(
+    {
+      name: "Open bot PR count",
+      topAscending: "optionparse",
+      topDescending: "govuk-blogs",
+    },
+    page
+  );
+
+  await testSortingForColumn(
+    {
+      name: "Open PR count",
+      topAscending: "optionparser",
+      topDescending: "php-missing",
+    },
+    page
+  );
+
+  await testSortingForColumn(
+    {
+      name: "Updated at",
+      topAscending: "optionparser",
+      topDescending: "govuk-blogs ",
+    },
+    page
+  );
 });
+
+const testSortingForColumn = async (
+  { name, topAscending, topDescending },
+  page
+) => {
+  await page.getByRole("link", { name, exact: true }).click();
+  await assertFirstDependencyRow(topAscending, page);
+
+  await page.getByRole("link", { name, exact: true }).click();
+  await assertFirstDependencyRow(topDescending, page);
+};
+
+const assertFirstDependencyRow = async (expectedFirstDependency, page) => {
+  const firstDependencyRow = page.getByRole("row").nth(1);
+  await expect(firstDependencyRow).toContainText(expectedFirstDependency);
+};