Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright #37

Merged
merged 5 commits into from
Sep 16, 2024
Merged

Add playwright #37

merged 5 commits into from
Sep 16, 2024

Commits on Sep 13, 2024

  1. Remove unused vars

    We're not using these so I'm not sure we need them here?
    rich committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    532b0f4 View commit details
    Browse the repository at this point in the history
  2. Remove middleware

    I don't think this does anything?
    And by removing it we can avoid having to call the Github API except
    when seeding data which makes running the tests a bit easier
    rich committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5cf5b07 View commit details
    Browse the repository at this point in the history
  3. Add playwright

    This adds the packages, config and a github action to run the tests
    rich committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    636a234 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Add seeding

    This adds a seeding job.
    Using live data is hard to assert against and means we have to run the
    seeding job which takes time and uses rate-limit tokens.
    Instead we copy across some test data we can use. This means the data
    will always be consistent and we can test against it more easily.
    We can't do this in a setup job [as Playwright
    recommends](https://playwright.dev/docs/test-global-setup-teardown)
    because the app depends on the JSON existing before it can start.
    Instead we have to copy and paste the seed data across before we start
    the app.
    rich committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6a6a58e View commit details
    Browse the repository at this point in the history
  2. Add first test

    This is trivial for now but once we have some functionality it will be
    more interesting
    rich committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    09e2364 View commit details
    Browse the repository at this point in the history