Add playwright #37
Merged
Add playwright #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richpjames
force-pushed
the
add-e2es
branch
2 times, most recently
from
1da22a6
to
805b69c
Compare
added 2 commits
September 13, 2024 14:47
We're not using these so I'm not sure we need them here?
I don't think this does anything? And by removing it we can avoid having to call the Github API except when seeding data which makes running the tests a bit easier
richpjames
force-pushed
the
add-e2es
branch
4 times, most recently
from
a116b1e
to
dd49fe6
Compare
This adds the packages, config and a github action to run the tests
richpjames
force-pushed
the
add-e2es
branch
from
dd49fe6
to
a8171d1
Compare
danlivings-dxw
approved these changes
Sep 13, 2024
added 2 commits
September 16, 2024 07:52
This adds a seeding job. Using live data is hard to assert against and means we have to run the seeding job which takes time and uses rate-limit tokens. Instead we copy across some test data we can use. This means the data will always be consistent and we can test against it more easily. We can't do this in a setup job [as Playwright recommends](https://playwright.dev/docs/test-global-setup-teardown) because the app depends on the JSON existing before it can start. Instead we have to copy and paste the seed data across before we start the app.
This is trivial for now but once we have some functionality it will be more interesting
richpjames
force-pushed
the
add-e2es
branch
from
a8171d1
to
09e2364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that changes committed aren't breaking things.
The functionality is trivial at the moment but soon (#36) we will introduce sorting. We will want to be able to test this.
This PR introduces Playwright for E2E tests.
Rather than seed the app with live data which will be hard to assert on we seed it with test data.