Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we are converting the project details from JSON to a String (format found in #85) #86

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

sohilpandya
Copy link
Member

we are converting the information to JSON
then converting the JSON to string
related to #85, #84.

please note
at this moment we are only converting this JSON when the user creates/starts a new timer.

we are converting the information to json
then converting the json to string
related to #85, #84
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sohilpandya LGTM. 👍

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iteles iteles merged commit 17f6e23 into master Jun 23, 2017
@iteles iteles deleted the converting-to-json branch June 23, 2017 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants