Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting the string to a SHA256 hash #89

Merged
merged 2 commits into from
Jun 23, 2017
Merged

Converting the string to a SHA256 hash #89

merged 2 commits into from
Jun 23, 2017

Conversation

sohilpandya
Copy link
Member

Please review & Merge after #86

Sohil Pandya added 2 commits June 22, 2017 16:29
we are converting the project details in the format found in #85
d2201fc 
we are converting the information to json
then converting the json to string
related to #85, #84
converting the string to a SHA256 hash.
4cd257b 
we need to use some objc-c code so needed to use something called a bridging header which would allow us to use some obcj-c code in swift
converting the json string to the hash in startTimer
related to #84, #87
nelsonic
nelsonic reviewed Jun 22, 2017
View reviewed changes
dwyl/time/stringToHash.swift

import Foundation

func sha256(_ data: Data) -> Data? {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sohilpandya this looks good. we're going to need to write a test to check for the output at some point soon but for now this is fine. thanks! 👍

nelsonic
nelsonic approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sohilpandya LGTM. 🎉

@nelsonic nelsonic removed their assignment Jun 22, 2017
iteles
iteles approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @sohilpandya, please add Nelson's comment to your list 👍

@iteles iteles merged commit 94fe853 into master Jun 23, 2017
@iteles iteles deleted the sha256-hash branch June 23, 2017 11:15
@sohilpandya
Copy link
Member Author

Thanks @iteles, updated the top comment on here #84 by adding the testing as a checklist.

@sohilpandya sohilpandya restored the sha256-hash branch July 13, 2017 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iteles iteles iteles approved these changes

@nelsonic nelsonic nelsonic approved these changes

Assignees

@iteles iteles

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sohilpandya @nelsonic @iteles