-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate SHA256 Hashing on iOS (Swift) #84
Comments
@sohilpandya please remember to add a Time Estimate to issues before diving in. 😉 |
Thanks for that @nelsonic. I've estimated 1.5 days for this, already spent ~3 hours on the first couple if items alongside the background reading. :) update
|
@nelsonic wanted a clarification on the following point:
At this moment we are storing the following information in core data: I will be adding an additional field in the core data called
Now when the user stops a timer, we are updating this item in the core data, would we update the hash too? as at the moment, the user starts a timer the hash contains the following infomation
But when the timer is stopped it should have an additional field of This will mean that the hash will be different when the timer is started and when the timer is stopped. |
@sohilpandya apologies if this is unclear. no, we are not updating the hash we are going to save a new revision. I am working on NHS today, but as soon as I have some time spare I will document exactly how this needs to work on both iOS and PWA so it's much clearerer. 👍 Meanwhile could you please write-up a "complete beginners" intro to automated UI testing in: https://github.com/dwyl/learn-apple-watch-development/ thanks! 🎉 |
Thanks for that! I'll probably like to catch up about it early Monday morning if we can, I will look into dwyl/learn-apple-watch-development#40 for the time being. 👍 |
@nelsonic can we catch up at some point today to talk about this? |
@sohilpandya dang. only saw this now... I expect to do some work on this on the train on Thursday. we should setup a hangout to catchup. 👍 |
Hey @nelsonic That would be awesome, I'm planning to start working full steam from tomorrow so be great if we could catch up first thing tomorrow if that is possible? |
We only have one table, some of the main bits of information it contains:
Here is the current flow of all the times we are storing to the core data
|
It appears to be possible to create a
SHA256
Hash in Swift:https://stackoverflow.com/questions/25388747/sha256-in-swift
Todo
id
fieldid:hash
)Background Reading
Note: the reason for using a
SHA256
instead of another hashing algorithm is: dwyl/learn-cryptography#2The text was updated successfully, but these errors were encountered: